Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qgis: don't build with grass by default #350203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

imincik
Copy link
Contributor

@imincik imincik commented Oct 21, 2024

Things done

Since #349247 , we are able to easily override some high level build
configuration parameters including GRASS support (withGrass). This PR is
disabling GRASS support by default for QGIS and QGIS LTR to make QGIS closure
smaller.

GRASS support can be enabled using qgis.override as following

  nix-build -E "with import ./. {}; qgis.override { withGrass = true; }"
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zi3m5f
Copy link
Contributor

zi3m5f commented Oct 21, 2024

As already suggested in
#281189 (comment)

changing a default should be documented and also checked with nixpkgs-review for breakage.

@imincik
Copy link
Contributor Author

imincik commented Oct 22, 2024

As already suggested in #281189 (comment)

changing a default should be documented and also checked with nixpkgs-review for breakage.

There is no package depending on QGIS, nixpkgs-review is not necessary. But good point with documenting the change.

@imincik
Copy link
Contributor Author

imincik commented Oct 22, 2024

As already suggested in #281189 (comment)

changing a default should be documented and also checked with nixpkgs-review for breakage.

Documentation added. Thanks.

@ofborg ofborg bot requested a review from l0b0 October 22, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants